-
Notifications
You must be signed in to change notification settings - Fork 111
Ensure wheel isn't restricted to specific interpreter version #556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This reverts commit 66c922f.
…ython-sdks into lukas/dont-infer-build
…ython-sdks into lukas/dont-infer-build
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
|
@codex Is hatch the right build system for this kind of project (native dependencies)? |
|
To use Codex here, create an environment for this repo. |
|
@codex Is hatch the right build system for this kind of project (native dependencies)? |
ResponseShort answer: Hatchling is a reasonable fit here because you’re not compiling a CPython extension; you’re bundling native shared libraries and shipping them as artifacts. The repo already uses a custom Hatch build hook to set platform tags appropriately for those native FFI assets, which is exactly the sort of customization hatchling supports. livekit-rtc/pyproject.tomlL1-L56 livekit-rtc/hatch_build.pyL1-L83 Why Hatchling is acceptable for native dependencies here
Avoiding “rewriting the platform tags logic”You already have centralized, reusable logic for platform tag selection in If you later change build systems, you can likely reuse the same helper logic from Suggested next stepIf the concern is portability or minimizing duplication:
If you want, I can propose a small refactor to make the platform tag logic reusable across build backends (while keeping hatchling in place). |
additionally updates e2e tests to use built wheels directly, see #557